public inbox for nncp-devel@lists.cypherpunks.ru
Atom feed
* nncp-file 7.0.0 broken with stdin
@ 2021-07-03 14:46 John Goerzen
  2021-07-03 15:22 ` John Goerzen
  2021-07-03 15:49 ` Sergey Matveev
  0 siblings, 2 replies; 3+ messages in thread
From: John Goerzen @ 2021-07-03 14:46 UTC (permalink / raw)
  To: nncp-devel

Hi Sergey,

Trying out NNCP 7.0.0, I'm having issues with nncp-file when 
reading from stdin:

2021-07-03T14:44:31Z ERROR File - (3 B) sent to bakfs:foo: 
chacha20poly1305: message authentication failed
main.go:135: chacha20poly1305: message authentication failed

When giving a file on the command line instead of -, it appears to 
be working.

Thanks!

- John

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: nncp-file 7.0.0 broken with stdin
  2021-07-03 14:46 nncp-file 7.0.0 broken with stdin John Goerzen
@ 2021-07-03 15:22 ` John Goerzen
  2021-07-03 15:49 ` Sergey Matveev
  1 sibling, 0 replies; 3+ messages in thread
From: John Goerzen @ 2021-07-03 15:22 UTC (permalink / raw)
  To: nncp-devel

Also, nncp-exec with -use-tmp appears to work but silently just 
doesn't send anything (returns exit code 0).  It seems there's 
something busted with both of these in stdin mode.

Thanks,

John

On Sat, Jul 03 2021, John Goerzen wrote:

> Hi Sergey,
>
> Trying out NNCP 7.0.0, I'm having issues with nncp-file when 
> reading from stdin:
>
> 2021-07-03T14:44:31Z ERROR File - (3 B) sent to bakfs:foo: 
> chacha20poly1305:
> message authentication failed
> main.go:135: chacha20poly1305: message authentication failed
>
> When giving a file on the command line instead of -, it appears 
> to be working.
>
> Thanks!
>
> - John

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: nncp-file 7.0.0 broken with stdin
  2021-07-03 14:46 nncp-file 7.0.0 broken with stdin John Goerzen
  2021-07-03 15:22 ` John Goerzen
@ 2021-07-03 15:49 ` Sergey Matveev
  1 sibling, 0 replies; 3+ messages in thread
From: Sergey Matveev @ 2021-07-03 15:49 UTC (permalink / raw)
  To: nncp-devel

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

Greetings!

*** John Goerzen [2021-07-03 09:46]:
> 2021-07-03T14:44:31Z ERROR File - (3 B) sent to bakfs:foo: chacha20poly1305:
> message authentication failed
> main.go:135: chacha20poly1305: message authentication failed

There was slight optimization of encryption function... that lead to the
error (nonce was updated by encryption function inplace, and decryption
code does not nullify it before the start). Thanks for the report! Fix
will be in the next release, already going to happen tomorrow

> Also, nncp-exec with -use-tmp appears to work but silently just doesn't send
> anything (returns exit code 0).  It seems there's something busted with both
> of these in stdin mode.

Thanks for the report. Silly error with variable shadowing.

I will definitely will start writing functional tests, calling the real
commands and testing that massive pile of possible options and cases. It
is a shame that I have not started them writing before of course. But in
the next release there is a very new functionality, bringing even more
complex use-cases and corner-cases.

-- 
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263  6422 AE1A 8109 E498 57EF

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-03 15:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-03 14:46 nncp-file 7.0.0 broken with stdin John Goerzen
2021-07-03 15:22 ` John Goerzen
2021-07-03 15:49 ` Sergey Matveev