public inbox for nncp-devel@lists.cypherpunks.ru
Atom feed
* [nncp-devel] crash in nncp-toss from mail packet
@ 2017-01-15 1:44 Shawn K. Quinn
2017-01-15 8:02 ` Sergey Matveev
0 siblings, 1 reply; 4+ messages in thread
From: Shawn K. Quinn @ 2017-01-15 1:44 UTC (permalink / raw)
To: nncp-devel
This is from feeding nncp-mail a short test message from the command
line by hand, on the system tossing them. Even if I'm doing it wrong,
this really shouldn't happen. Worse, this crash will keep happening on
any later run of nncp-toss (on the receiving system) until the packet is
manually deleted.
panic: runtime error: slice bounds out of range
goroutine 1 [running]:
panic(0x68ec00, 0xc82000a070)
/usr/lib/go-1.6/src/runtime/panic.go:481 +0x3e6
cypherpunks.ru/nncp.(*Ctx).Toss(0xc820058550, 0xc82000f820,
0xc8200900ff, 0xc820058500)
/home/skquinn/usr/src/nncp-0.1/src/cypherpunks.ru/nncp/toss.go:140 +0x3e82
main.main()
/home/skquinn/usr/src/nncp-0.1/src/cypherpunks.ru/nncp/cmd/nncp-toss/main.go:89 +0xc47
--
Shawn K. Quinn <skquinn@rushpost•com>
http://www.rantroulette.com
http://www.skqrecordquest.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [nncp-devel] crash in nncp-toss from mail packet
2017-01-15 1:44 [nncp-devel] crash in nncp-toss from mail packet Shawn K. Quinn
@ 2017-01-15 8:02 ` Sergey Matveev
2017-01-15 10:23 ` Shawn K. Quinn
0 siblings, 1 reply; 4+ messages in thread
From: Sergey Matveev @ 2017-01-15 8:02 UTC (permalink / raw)
To: nncp-devel
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
*** Shawn K. Quinn <skquinn@rushpost•com> [2017-01-15 04:46]:
>This is from feeding nncp-mail a short test message from the command
>line by hand, on the system tossing them. Even if I'm doing it wrong,
>this really shouldn't happen.
Fully agreed that those kind of errors must not occur at all. Fixed in
https://git.cypherpunks.ru/cgit.cgi/nncp.git/commit/?h=develop&id=8cfca6f25358b2ce75abd2b410e28e5b5008413b
it is because "sendmail" configuration field is not set for the node.
No it will skip this packet with warning message about unconfigured
sendmail.
Thanks for bugreporting!
I think that will release the next version of NNCP today.
--
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263 6422 AE1A 8109 E498 57EF
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [nncp-devel] crash in nncp-toss from mail packet
2017-01-15 8:02 ` Sergey Matveev
@ 2017-01-15 10:23 ` Shawn K. Quinn
2017-01-15 10:45 ` Sergey Matveev
0 siblings, 1 reply; 4+ messages in thread
From: Shawn K. Quinn @ 2017-01-15 10:23 UTC (permalink / raw)
To: nncp-devel
[-- Attachment #1.1: Type: text/plain, Size: 1843 bytes --]
On 01/15/2017 02:02 AM, Sergey Matveev wrote:
> *** Shawn K. Quinn <skquinn@rushpost•com> [2017-01-15 04:46]:
>> This is from feeding nncp-mail a short test message from the command
>> line by hand, on the system tossing them. Even if I'm doing it wrong,
>> this really shouldn't happen.
>
> Fully agreed that those kind of errors must not occur at all. Fixed in
> https://git.cypherpunks.ru/cgit.cgi/nncp.git/commit/?h=develop&id=8cfca6f25358b2ce75abd2b410e28e5b5008413b
> it is because "sendmail" configuration field is not set for the node.
> No it will skip this packet with warning message about unconfigured
> sendmail.
OK, noted. That means we need this to be explained in the documentation,
which thankfully is something I can help out with. I plan to submit a
patch fixing as many grammar, spelling, and other minor errors that I
can find in the texinfo file as time allows (hopefully next couple of
days, but certainly by the end of January).
It would make more sense to me, BTW, to allow defaults for all nodes for
the incoming, freq, and sendmail options, with pattern matching
substitution for node names (for incoming I would still find separating
by sending node useful as opposed to lumping it all in one place).
Perhaps by allowing a configuration section "default:" similar to the
current "self:"? I can think of more cases where I'd want all nodes to
be able to send files to me and freq files from me than I would where
I'd want only some.
Also, is it necessarily a design goal of the project for everything to
be written in Go? I am considering writing a GUI front-end but I am
completely new to Go and I am reading that desktop GUI apps are so far
not a common use case for Go.
--
Shawn K. Quinn <skquinn@rushpost•com>
http://www.rantroulette.com
http://www.skqrecordquest.com
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [nncp-devel] crash in nncp-toss from mail packet
2017-01-15 10:23 ` Shawn K. Quinn
@ 2017-01-15 10:45 ` Sergey Matveev
0 siblings, 0 replies; 4+ messages in thread
From: Sergey Matveev @ 2017-01-15 10:45 UTC (permalink / raw)
To: nncp-devel
[-- Attachment #1: Type: text/plain, Size: 2277 bytes --]
*** Shawn K. Quinn <skquinn@rushpost•com> [2017-01-15 13:25]:
>OK, noted. That means we need this to be explained in the documentation,
Will note that.
>which thankfully is something I can help out with. I plan to submit a
>patch fixing as many grammar, spelling, and other minor errors that I
>can find in the texinfo file as time allows (hopefully next couple of
>days, but certainly by the end of January).
That will be helpful, because I am not native english speaker, so there
are possibly plenty of them.
>It would make more sense to me, BTW, to allow defaults for all nodes for
>the incoming, freq, and sendmail options, with pattern matching
>substitution for node names (for incoming I would still find separating
>by sending node useful as opposed to lumping it all in one place).
>Perhaps by allowing a configuration section "default:" similar to the
>current "self:"? I can think of more cases where I'd want all nodes to
>be able to send files to me and freq files from me than I would where
>I'd want only some.
Well, I assumed (however currently did not use by myself) that YAML will
help in that task: it has ability to make references to already defined
sections. But I need to think about it better for convenient usage.
>Also, is it necessarily a design goal of the project for everything to
>be written in Go? I am considering writing a GUI front-end but I am
>completely new to Go and I am reading that desktop GUI apps are so far
>not a common use case for Go.
Well, Go is not design goal for that project, but it is worth for it. I
like it very much -- so obviously this is the main reason for its
choosing.
I do not use GUI at all (except rare minor exceptions to run browser)
and won't use it anyway. So for me GUI is not interesting at all. I am
against including anything related to GUI in NNCP tarball, and I think
it is better to keep source code separate (not to force developers to
install GUI-related things for working just with NNCP alone) from the
mainline. But of course I do not see any obstacles in building another
tarball with GUI-related things, possibly on other language.
--
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263 6422 AE1A 8109 E498 57EF
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-15 10:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-15 1:44 [nncp-devel] crash in nncp-toss from mail packet Shawn K. Quinn
2017-01-15 8:02 ` Sergey Matveev
2017-01-15 10:23 ` Shawn K. Quinn
2017-01-15 10:45 ` Sergey Matveev