public inbox for goredo-devel@lists.cypherpunks.ru
Atom feed
* redo-whichdo broken
@ 2023-11-10 17:38 spacefrogg
2023-11-11 20:11 ` Sergey Matveev
0 siblings, 1 reply; 4+ messages in thread
From: spacefrogg @ 2023-11-10 17:38 UTC (permalink / raw)
To: Goredo Devel
Hi,
since goredo 2.1.0 the output of redo-whichdo is broken. Minimum
example: A directory containing only a default.do file (content
irrelevant). Run redo-whichdo a/b/c.d.
Expected output:
a/b/c.d.do
a/b/default.d.do
a/b/default.do
a/default.d.do
a/default.do
default.d.do
default.do
Returned output:
../../default.d.do
../default.d.do
../default.do
c.d.do
default.d.do
default.do
default.do
Kind regards,
–Michael
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: redo-whichdo broken
2023-11-10 17:38 redo-whichdo broken spacefrogg
@ 2023-11-11 20:11 ` Sergey Matveev
2023-11-17 13:12 ` spacefrogg
0 siblings, 1 reply; 4+ messages in thread
From: Sergey Matveev @ 2023-11-11 20:11 UTC (permalink / raw)
To: goredo-devel
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
Greetings!
*** spacefrogg [2023-11-10 17:38]:
>since goredo 2.1.0 the output of redo-whichdo is broken.
Thank you very much for the report! Fixed in 2.3.0 release.
After huge refactoring related to paths handling, obvious
mistakes appeared in whichdo's code indeed. And non-default
(redo, -ifcreate, -ifchange) commands are less extensively
covered by tests.
--
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: 12AD 3268 9C66 0D42 6967 FD75 CB82 0563 2107 AD8A
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: redo-whichdo broken
2023-11-11 20:11 ` Sergey Matveev
@ 2023-11-17 13:12 ` spacefrogg
2023-11-17 16:18 ` Sergey Matveev
0 siblings, 1 reply; 4+ messages in thread
From: spacefrogg @ 2023-11-17 13:12 UTC (permalink / raw)
To: goredo-devel
Hi,
I tried the new version 2.3.0 and the fix is only partial. At least
there is an inconsistency with the old behaviour of redo-whichdo. When
it does not find any .do file up to the filesystem root, it, now, prints
an error message and no list of .do files. It should not do that. At
least for what I use it for, this is useless behaviour. It should rather
print the whole list (up to /default.do) and terminate with an error
code to signal that although it printed the list, the last file is still
not valid. This is what the previous redo-whichdo did, and which was
much more useful.
Regards,
–Michael
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: redo-whichdo broken
2023-11-17 13:12 ` spacefrogg
@ 2023-11-17 16:18 ` Sergey Matveev
0 siblings, 0 replies; 4+ messages in thread
From: Sergey Matveev @ 2023-11-17 16:18 UTC (permalink / raw)
To: goredo-devel
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
Greetings!
*** spacefrogg [2023-11-17 13:12]:
>I tried the new version 2.3.0 and the fix is only partial.
Indeed I forgot that error during do-s searching is expected thing.
Fixed in 2.4.0 release. Thank you for the feedback!
--
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: 12AD 3268 9C66 0D42 6967 FD75 CB82 0563 2107 AD8A
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-17 16:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-10 17:38 redo-whichdo broken spacefrogg
2023-11-11 20:11 ` Sergey Matveev
2023-11-17 13:12 ` spacefrogg
2023-11-17 16:18 ` Sergey Matveev