public inbox for goredo-devel@lists.cypherpunks.ru
Atom feed
* Redo targets built twice during single run
@ 2021-10-26 9:21 goredo
2021-10-27 7:32 ` Sergey Matveev
0 siblings, 1 reply; 2+ messages in thread
From: goredo @ 2021-10-26 9:21 UTC (permalink / raw)
To: goredo-devel
Hi,
I had the feeling for some time that some targets get built a second time during a single run and now I've found an MWE. You need the following dependency graph:
- lvl1: lvl3 lvl2
- lvl2: lvl3
- lvl3
As you can see, lvl1 and lvl2 both depend on lvl3. The bug is triggered, when the arguments to redo-ifchange in lvl1 are as shown above, with lvl3 coming before lvl2. Then, redo misses to communicate that it has already built the dependency of lvl2 and lvl3 gets built a second time.
```
Level 3 executed
redo . lvl3 (0.003s)
Level 3 executed
redo . . lvl3 (0.003s)
redo . lvl2 (0.014s)
redo lvl1 (0.038s)
```
This only happens when redo is run with -j 1.
Kind regards,
–Michael
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Redo targets built twice during single run
2021-10-26 9:21 Redo targets built twice during single run goredo
@ 2021-10-27 7:32 ` Sergey Matveev
0 siblings, 0 replies; 2+ messages in thread
From: Sergey Matveev @ 2021-10-27 7:32 UTC (permalink / raw)
To: goredo-devel
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
Greetings!
*** goredo [2021-10-26 09:21]:
>This only happens when redo is run with -j 1.
Thanks again for the bugreport! That was regression since the release
that passed OOD targets to dependencies, and they skipped OOD check for
that "cached known OODs". Actually it was reproducible for me not only
with "-j 1", because of race. Fixed in 1.18.0 release.
--
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263 6422 AE1A 8109 E498 57EF
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-27 7:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 9:21 Redo targets built twice during single run goredo
2021-10-27 7:32 ` Sergey Matveev