public inbox for goredo-devel@lists.cypherpunks.ru
Atom feed
* redo silently fails when creating target directly
@ 2021-09-30  8:46 goredo
  2021-09-30 11:07 ` Sergey Matveev
  0 siblings, 1 reply; 2+ messages in thread
From: goredo @ 2021-09-30  8:46 UTC (permalink / raw)
  To: goredo-devel

I just discovered that redo silently fails when a .do script creates the target on its own without using $3.
In that case the call succeeds and no target file is left after the run.

I would expect it to fail loudly.

I also suspect errors in dependency handling, when building targets in adjacent sub trees, i.e., redo ../foo/bar. After doing this and calling another target ../foo/baz, that depends on it, ../foo/bar gets rebuilt. I'm still working on an MWE, though.

–Michael

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: redo silently fails when creating target directly
  2021-09-30  8:46 redo silently fails when creating target directly goredo
@ 2021-09-30 11:07 ` Sergey Matveev
  0 siblings, 0 replies; 2+ messages in thread
From: Sergey Matveev @ 2021-09-30 11:07 UTC (permalink / raw)
  To: goredo-devel

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

Greetings!

*** goredo [2021-09-30 08:46]:
>I would expect it to fail loudly.

Fully agree that it have to fail! Actually there was check if $1 is
touched/modifier, but not appeared. Fixed in 1.15.0 release. Thank you!

-- 
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263  6422 AE1A 8109 E498 57EF

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-30 11:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30  8:46 redo silently fails when creating target directly goredo
2021-09-30 11:07 ` Sergey Matveev