public inbox for nncp-devel@lists.cypherpunks.ru
Atom feed
From: Sergey Matveev <stargrave@stargrave•org>
To: nncp-devel@lists.cypherpunks.ru
Subject: Re: Bug with chunked files
Date: Sat, 29 Apr 2023 14:07:06 +0300	[thread overview]
Message-ID: <ZEz6W5VHuvZR24DD@stargrave.org> (raw)
In-Reply-To: <CAACH8H8DrR-eeGFT1_gxuaWm2XkcLepq7cqMLf0nTt4uckZ7GA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Greetings!

*** AsmodeusB [2023-04-28 12:42]:
>It looks like there is a bug with chunked files where the file size is an
>integer multiple of the chunk size.

Thanks for the report! Indeed there was a bug in nncp-reass logic for
the last chunk:
    badSize = uint64(fi.Size()) != metaPkt.FileSize%metaPkt.ChunkSize

Fixed in 8.8.3 release.

-- 
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: 12AD 3268 9C66 0D42 6967  FD75 CB82 0563 2107 AD8A

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-04-29 11:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28 16:42 Bug with chunked files AsmodeusB
2023-04-29 11:07 ` Sergey Matveev [this message]
2023-05-01 17:16   ` AsmodeusB