public inbox for goredo-devel@lists.cypherpunks.ru
Atom feed
From: Sergey Matveev <stargrave@stargrave•org>
To: goredo-devel@lists.cypherpunks.ru
Subject: Re: File mode changes not properly updated for existing targets
Date: Sat, 7 Oct 2023 17:29:29 +0300	[thread overview]
Message-ID: <ZSFrSSp_LNBd1x5R@stargrave.org> (raw)
In-Reply-To: <9e4d15ee0b1d395a8cb9bdbeabe6a7eb@spacefrogg.net>

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

Greetings!

*** spacefrogg [2023-10-05 14:21]:
>Could it be, that you are doing "cat" instead of "mv" on an existing target
>to avoid changing the inode?

Definitely not, because, as you correctly noted, that would be
non-atomic operation.

>Okay, further testing showed that file modes are not updated exactly when
>the content of the target did not change. So, after checking the content of
>$3 and the old target, goredo should still update the mode bits. :)

Agreed, forget to take it into account! Will copy the mode of the file
to the target even if it is not renamed because of identical contents.

-- 
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: 12AD 3268 9C66 0D42 6967  FD75 CB82 0563 2107 AD8A

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      parent reply	other threads:[~2023-10-07 14:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-05 14:21 File mode changes not properly updated for existing targets spacefrogg
2023-10-05 14:23 ` spacefrogg
2023-10-05 14:28 ` Jan Niklas Böhm
2023-10-07 14:26   ` Sergey Matveev
2023-10-07 14:29 ` Sergey Matveev [this message]