public inbox for goredo-devel@lists.cypherpunks.ru
Atom feed
From: Sergey Matveev <stargrave@stargrave•org>
To: goredo-devel@lists.cypherpunks.ru
Subject: Re: redo-ifchange hangs when called with many arguments
Date: Thu, 21 Oct 2021 12:51:31 +0300	[thread overview]
Message-ID: <YXE4L7P+TgaC/3Js@stargrave.org> (raw)
In-Reply-To: <4fe528dc-60d8-4cd9-920d-999c025aedc3@spacefrogg.net>

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

*** goredo [2021-10-19 16:05]:
>I will limit argument passing to mitigate the bug.

I think that it is good enough workaround. If I met that kind of
freezing (again) and won't find the reason (possibly because do not have
time to investigate it clearly), I would just limit number of arguments
(xargs/whatever).

>Maybe, this warrants a note on the FAQ with descriptions of possible workarounds...

Well, I assume that with literally every program you have to remember
about OS environment it is running under. So that would be excess
information. And everybody who uses redo will already know about xargs
and similar tools. Of course, in my humble opinion.

>You could make redo work conservatively and not inspect more dependencies in parallel than jobs are allowed to start anyhow.
>(I honestly don't know, at what point those many files get opened.)

It could be done, yes, probably I will add it soon. When you pass 1000
targets, when 1000 goroutines will run, at least with opened target's
.lock file, waiting when free job slot token will arrive. Target that
waits for children to finish (dependencies) at least holds opened files
with .dep metainformation and at least stderr pipe. So yeah, jobs number
does not limit opened files number.

-- 
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263  6422 AE1A 8109 E498 57EF

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-10-21 10:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-16 15:58 redo-ifchange hangs when called with many arguments goredo
2021-10-19 13:58 ` Sergey Matveev
2021-10-19 14:56   ` goredo
2021-10-19 15:26     ` Sergey Matveev
2021-10-19 16:05       ` goredo
2021-10-21  9:51         ` Sergey Matveev [this message]