public inbox for goredo-devel@lists.cypherpunks.ru
Atom feed
From: Sergey Matveev <stargrave@stargrave•org>
To: goredo-devel@lists.cypherpunks.ru
Subject: Re: OOD checking done too eagerly
Date: Fri, 22 Jan 2021 19:12:26 +0300	[thread overview]
Message-ID: <YAr5alsQ31DErWa7@stargrave.org> (raw)
In-Reply-To: <87pn1x806w.fsf@paris.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

Greetings!

*** spacefrogg-goredo@spacefrogg•net [2021-01-22 16:23]:
>So, process 30334 (redo-ifchange b) runs the complete dependency
>chain down to the source x, determining that b must be OOD.
>[...]
>The problem is, the dependency chain behind a could be arbitrarily
>large, forcing redo to do this expensive calculation unnecessarily
>often.

All redo-ifchange instances do the same OOD detection again, because
they do not share already made (by another instance) OOD-decisions.

I completely agreed that they are unnecessary and relatively expensive
at least because of continuous state files opening and reading. Of
course because of filesystem's metadata cache, there should be no
additional disk activity, but burnt CPU cycles and context switches
because of syscalls.

Currently, I have no plans in that direction, because it is far from
being the bottleneck. But some day it should be optimized of course.

-- 
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263  6422 AE1A 8109 E498 57EF

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-01-22 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87sg6t80s8.fsf@paris.i-did-not-set--mail-host-address--so-tickle-me>
2021-01-22 15:23 ` OOD checking done too eagerly spacefrogg-goredo
2021-01-22 16:12   ` Sergey Matveev [this message]
2021-01-22 16:24     ` Sergey Matveev