public inbox for goredo-devel@lists.cypherpunks.ru
Atom feed
From: goredo <spacefrogg-goredo@spacefrogg•net>
To: goredo-devel@lists.cypherpunks.ru
Subject: Re: [PATCH] Don't create nested target directories automatically
Date: Fri, 15 Apr 2022 13:17:10 +0000 (UTC)	[thread overview]
Message-ID: <96b4042d-a742-481e-9891-676cb9a0c6c9@spacefrogg.net> (raw)
In-Reply-To: <35d96894-b951-1b56-5329-5ef4a9fcf26e@acha.ninja>

I may have misunderstood you. I thought, you wanted redo to fail immediately, once it is called on a target in an non-existent directory. Okay, the contract, then, would be, that you'd have to create the directory before writing. Which, of course, is reasonable.

Next situation: In goredo, it is legal and wanted, that you can implement always-out-of-date targets by not creating any output. You would still need the directory to store the record for that target. And it would not be obvious, why you'd have to have a mkdir call, when you don't want to write something. Those would also pollute apenwarr user's trees, who don't have to do that.

One suggestion to your patch: Instead of failing, you could defer creating the directory to the point where redo actually wants to write a record to a file.

  reply	other threads:[~2022-04-15 13:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15  0:55 [PATCH] Don't create nested target directories automatically Andrew Chambers
2022-04-15  6:10 ` goredo
2022-04-15  6:49   ` Andrew Chambers
2022-04-15  7:15     ` goredo
2022-04-15  7:31       ` Andrew Chambers
2022-04-15  9:28         ` goredo
2022-04-15 12:00           ` Andrew Chambers
2022-04-15 13:17             ` goredo [this message]
2022-04-15 13:39               ` Andrew Chambers
2022-04-15 13:58                 ` goredo
2022-04-15 16:23               ` Sergey Matveev
2022-04-16  0:36                 ` Andrew Chambers
2022-04-15 16:23     ` Sergey Matveev
2022-04-15  6:57   ` Andrew Chambers
2022-04-15 16:23 ` Sergey Matveev